Skip to content

Remove deprecated on_init_start_end#14867

Merged
awaelchli merged 8 commits intoLightning-AI:masterfrom
AndresAlgaba:feature/remove/on_init_start_end
Sep 30, 2022
Merged

Remove deprecated on_init_start_end#14867
awaelchli merged 8 commits intoLightning-AI:masterfrom
AndresAlgaba:feature/remove/on_init_start_end

Conversation

@AndresAlgaba
Copy link
Copy Markdown
Contributor

@AndresAlgaba AndresAlgaba commented Sep 23, 2022 •
edited by Borda
Loading

What does this PR do?

Removes deprecated APIs for 1.8 release, #14841. More specifically, the removal of test_v1_8_0_on_init_start_end.

resolves #10940

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or minor internal changes/refactors)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing, make sure you have read the review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@AndresAlgaba AndresAlgaba marked this pull request as draft September 23, 2022 10:29
@awaelchli
Copy link
Copy Markdown
Contributor

awaelchli commented Sep 23, 2022

@AndresAlgaba I saw your message earlier and if you have trouble running the tests let me know. You can also check the output of the CI here, for example Test PyTorch full / pl-cpu (ubuntu-20.04, 3.10, latest, stable). There may be some jobs failing that are unrelated to your PR.

AndresAlgaba
AndresAlgaba commented Sep 23, 2022
View reviewed changes
@krishnakalyan3 krishnakalyan3 mentioned this pull request Sep 23, 2022
Closed
23 tasks
@awaelchli awaelchli added breaking change Includes a breaking change community This PR is from the community callback labels Sep 23, 2022
@awaelchli awaelchli modified the milestones: pl:1.7.x, pl:1.8 Sep 23, 2022
awaelchli
awaelchli approved these changes Sep 23, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@awaelchli awaelchli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @AndresAlgaba
Feel free to mark the PR as ready for review 😃

carmocca
carmocca approved these changes Sep 23, 2022
View reviewed changes
@awaelchli awaelchli mentioned this pull request Sep 23, 2022
Closed
@krishnakalyan3
Copy link
Copy Markdown
Contributor

krishnakalyan3 commented Sep 24, 2022

great work @AndresAlgaba

@AndresAlgaba @awaelchli
Update src/pytorch_lightning/CHANGELOG.md
d3bc11d 
Co-authored-by: Adrian Wälchli <aedu.waelchli@gmail.com>
@AndresAlgaba AndresAlgaba marked this pull request as ready for review September 24, 2022 17:40
@mergify mergify bot added ready to be merged PRs ready to be merged and removed has conflicts ready to be merged PRs ready to be merged labels Sep 28, 2022
@akihironitta akihironitta added the hooks Related to the hooks API label Sep 28, 2022
@carmocca carmocca added the pl Generic label for PyTorch Lightning package label Sep 29, 2022
@github-actions github-actions bot removed the pl Generic label for PyTorch Lightning package label Sep 30, 2022
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 30, 2022 •
edited
Loading

Codecov Report

Merging #14867 (2357cf2) into master (abea29b) will increase coverage by 1%.
The diff coverage is n/a.

❗ Current head 2357cf2 differs from pull request most recent head e9ee5fc. Consider uploading reports for the commit e9ee5fc to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##           master   #14867     +/-   ##
=========================================
+ Coverage      83%      84%     +1%     
=========================================
  Files         395      327     -68     
  Lines       28832    25513   -3319     
=========================================
- Hits        23902    21371   -2531     
+ Misses       4930     4142    -788

@github-actions github-actions bot added the pl Generic label for PyTorch Lightning package label Sep 30, 2022
@awaelchli awaelchli enabled auto-merge (squash) September 30, 2022 11:56
@awaelchli awaelchli merged commit 3daa4c9 into Lightning-AI:master Sep 30, 2022
@awaelchli awaelchli mentioned this pull request Oct 10, 2022
Merged
11 tasks
@Alnusjaponica Alnusjaponica mentioned this pull request Jan 5, 2023
Closed
@Alnusjaponica Alnusjaponica mentioned this pull request Jan 13, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@tchaton tchaton Awaiting requested review from tchaton tchaton is a code owner

@ananthsub ananthsub Awaiting requested review from ananthsub

@manskx manskx Awaiting requested review from manskx

@lantiga lantiga Awaiting requested review from lantiga

@Borda Borda Awaiting requested review from Borda

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@rohitgr7 rohitgr7 Awaiting requested review from rohitgr7

@otaj otaj Awaiting requested review from otaj

@edenlightning edenlightning Awaiting requested review from edenlightning

@Felonious-Spellfire Felonious-Spellfire Awaiting requested review from Felonious-Spellfire

3 more reviewers

@awaelchli awaelchli awaelchli approved these changes

@carmocca carmocca carmocca approved these changes

@akihironitta akihironitta akihironitta approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@awaelchli awaelchli

@AndresAlgaba AndresAlgaba

Labels

breaking change Includes a breaking change callback community This PR is from the community hooks Related to the hooks API pl Generic label for PyTorch Lightning package ready to be merged PRs ready to be merged

Projects

No open projects
Frameworks Planning
Status: Done

Milestone

v1.8

Development

Successfully merging this pull request may close these issues.

6 participants

@AndresAlgaba @awaelchli @krishnakalyan3 @carmocca @akihironitta @otaj