Skip to content

Deprecate callback hooks on_init_start and on_init_end#10940

Merged
daniellepintz merged 16 commits intoLightning-AI:masterfrom
daniellepintz:on_init_start
Dec 8, 2021
Merged

Deprecate callback hooks on_init_start and on_init_end#10940
daniellepintz merged 16 commits intoLightning-AI:masterfrom
daniellepintz:on_init_start

Conversation

@daniellepintz
Copy link
Copy Markdown
Contributor

@daniellepintz daniellepintz commented Dec 4, 2021 •
edited by ananthsub
Loading

What does this PR do?

Fixes #10894

Does your PR introduce any breaking changes? If yes, please list them.

Before submitting

  • Was this discussed/approved via a GitHub issue? (not for typos and docs)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together?
  • Did you make sure to update the documentation with your changes? (if necessary)
  • Did you write any new necessary tests? (not for typos and docs)
  • Did you verify new and existing tests pass locally with your changes?
  • Did you list all the breaking changes introduced by this pull request?
  • Did you update the CHANGELOG? (not for typos, docs, test updates, or internal minor changes/refactorings)

PR review

Anyone in the community is welcome to review the PR.
Before you start reviewing make sure you have read Review guidelines. In short, see the following bullet-list:

  • Is this pull request ready for review? (if not, please submit in draft mode)
  • Check that all items from Before submitting are resolved
  • Make sure the title is self-explanatory and the description concisely explains the PR
  • Add labels and milestones (and optionally projects) to the PR so it can be classified

Did you have fun?

Make sure you had fun coding 🙃

@daniellepintz daniellepintz marked this pull request as draft December 4, 2021 20:58
@daniellepintz daniellepintz marked this pull request as ready for review December 5, 2021 20:40
daniellepintz
daniellepintz commented Dec 5, 2021
View reviewed changes
@awaelchli awaelchli added the deprecation Includes a deprecation label Dec 6, 2021
@mergify mergify bot added the has conflicts label Dec 6, 2021
@mergify mergify bot removed the has conflicts label Dec 7, 2021
ananthsub
ananthsub reviewed Dec 7, 2021
View reviewed changes
@ananthsub ananthsub added this to the 1.6 milestone Dec 7, 2021
rohitgr7
rohitgr7 reviewed Dec 7, 2021
View reviewed changes
awaelchli
awaelchli approved these changes Dec 7, 2021
View reviewed changes
@mergify mergify bot added the ready to be merged PRs ready to be merged label Dec 7, 2021
@daniellepintz daniellepintz enabled auto-merge (squash) December 7, 2021 20:06
tchaton
tchaton approved these changes Dec 7, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@tchaton tchaton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 7, 2021 •
edited
Loading

Codecov Report

Merging #10940 (8da7733) into master (aeb0b55) will increase coverage by 32%.
The diff coverage is 100%.

❗ Current head 8da7733 differs from pull request most recent head 5158264. Consider uploading reports for the commit 5158264 to get more accurate results

@@            Coverage Diff            @@
##           master   #10940     +/-   ##
=========================================
+ Coverage      56%      88%    +32%     
=========================================
  Files         177      177             
  Lines       16545    16526     -19     
=========================================
+ Hits         9340    14548   +5208     
+ Misses       7205     1978   -5227

@mergify mergify bot added the has conflicts label Dec 8, 2021
@mergify mergify bot removed the has conflicts label Dec 8, 2021
@daniellepintz daniellepintz merged commit 01f5f99 into Lightning-AI:master Dec 8, 2021
@daniellepintz daniellepintz deleted the on_init_start branch December 8, 2021 17:26
This was referenced Dec 16, 2021
Merged
Closed
This was referenced Jan 21, 2022
Closed
Closed
Closed
@daniellepintz daniellepintz mentioned this pull request Jan 28, 2022
Merged
12 tasks
@Alnusjaponica Alnusjaponica mentioned this pull request Jan 5, 2023
Closed
@Alnusjaponica Alnusjaponica mentioned this pull request Jan 13, 2023
Merged
@Borda Borda mentioned this pull request Mar 9, 2023
Merged
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tchaton tchaton tchaton approved these changes

@Borda Borda Awaiting requested review from Borda

@carmocca carmocca Awaiting requested review from carmocca

@justusschock justusschock Awaiting requested review from justusschock justusschock is a code owner

@kaushikb11 kaushikb11 Awaiting requested review from kaushikb11

@SeanNaren SeanNaren Awaiting requested review from SeanNaren

@williamFalcon williamFalcon Awaiting requested review from williamFalcon

@edenlightning edenlightning Awaiting requested review from edenlightning

+3 more reviewers

@ananthsub ananthsub ananthsub approved these changes

@awaelchli awaelchli awaelchli approved these changes

@rohitgr7 rohitgr7 rohitgr7 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

deprecation Includes a deprecation ready to be merged PRs ready to be merged

Projects

None yet

Milestone

pl:1.6

Development

Successfully merging this pull request may close these issues.

[RFC] Deprecate callback hooks on_init_start and on_init_end

5 participants

@daniellepintz @ananthsub @awaelchli @tchaton @rohitgr7