Levelup from leveldown#342
Levelup from leveldown#342ralphtheninja wants to merge 10 commits intoLevel:masterfrom ralphtheninja:levelup-from-leveldown
Conversation
There was a problem hiding this comment.
why is that still a function? i think now is a good time to enable options.db = down
There was a problem hiding this comment.
ah I see in the tests that that already works, so we can simplify here?
There was a problem hiding this comment.
Yes. This if-statement looks terrible :) Imo the best would be to remove the location parameter completely.
There was a problem hiding this comment.
Shall me make it only this:
var db = levelup(leveldown(location))There was a problem hiding this comment.
Skip the callback completely?
There was a problem hiding this comment.
I'm all for simplifying, but I'd prefer to do all of that in a separate PR. I guess that change will involve a new major?
|
given #299 (comment), we should document that the leveldown must not have been opened |
|
Agree. I'll update README. |
|
Locking PR until leveldown can keep track of its own open state. |
Re-creating #299 as a new PR with cherry picked commits. Also using
isLevelDOWN()fromabstract-leveldown.