This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Merged
Conversation
Using a few C flags and linker flags, mostly related to Position Independent Code (PIC)
Member
|
Nice! Should be safe to merge straight away since it doesn't interfere with any of the other OSes. Q: Should this be a patch or a minor? cc @vweevers @juliangruber |
Member
|
Adding a new platform should be a new feature, I say minor. Great work, @staltz! 👏 |
Member
|
Will publish |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a few C flags and linker flags, mostly related to Position Independent Code (PIC). Also was important to not set
-mfloat-abi=hardbut rather let each Android architecture decide whether to use hard or soft.I tested this on both arm and arm64 real devices. Also used it in a real use case, so these proposed changes are battle tested.