Skip to content
This repository was archived by the owner on Dec 1, 2024. It is now read-only.
/ leveldown Public archive

Close database on environment exit#783

Merged
vweevers merged 1 commit intomasterfrom
close-on-environment-exit
Sep 12, 2021
Merged

Close database on environment exit#783
vweevers merged 1 commit intomasterfrom
close-on-environment-exit

Conversation

@vweevers
Copy link
Member

Closes #667, closes #755.

@vweevers vweevers added the semver-patch Bug fixes that are backward compatible label Sep 11, 2021
@vweevers vweevers requested review from peakji and ralphtheninja and removed request for peakji and ralphtheninja September 11, 2021 13:26
@vweevers vweevers marked this pull request as draft September 11, 2021 13:28
@vweevers

This comment has been minimized.

@ralphtheninja
Copy link
Member

Looks really nice!

@vweevers vweevers force-pushed the close-on-environment-exit branch from 66454c8 to 6a624ed Compare September 11, 2021 16:24
@vweevers vweevers marked this pull request as ready for review September 11, 2021 16:30
@vweevers vweevers merged commit 8fdcaaa into master Sep 12, 2021
@vweevers vweevers deleted the close-on-environment-exit branch September 12, 2021 09:12
@vweevers
Copy link
Member Author

6.0.2

jonathan-gramain added a commit to scality/s3utils that referenced this pull request Sep 28, 2022
This brings the leveldown version to 6.1.0 which has fixes that could
prevent an assert from happening in leveldb.

Level/leveldown#783

Level/leveldown#755
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

semver-patch Bug fixes that are backward compatible

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Multiple Assertion Failed !! weak reference cleanup

2 participants