This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Build a universal binary to support M1 (Apple silicon)#781
Merged
Conversation
Closed
vweevers
commented
Aug 29, 2021
be7d6e4 to
8c67622
Compare
Nazgolze
added a commit
to Nazgolze/rocksdb
that referenced
this pull request
Sep 24, 2021
an9949an
pushed a commit
to an9949an/leveldown
that referenced
this pull request
Aug 15, 2023
On mac, the prebuilt binary (as well as the binary built by `npm i --build-from-source`) is now a universal binary that's suitable for both x86_64 (as before) and arm64 (new). Also sets MACOSX_DEPLOYMENT_TARGET, to 10.7 which is the same target that Node.js 10 uses and thus what we already supported, but now explicitly. Ref Level#766 (cherry picked from commit 26ea717)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #766. Depends on prebuild/prebuildify#53 and prebuild/node-gyp-build#40.