This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Merged
Conversation
Problem: Leveldown takes a long time to build on low-end devices like the Pi Zero, and it would be really cool to add a prebuild for ARMv6. Solution: I've added a Docker image in the prebuild/docker-images repository and added ARMv6 to the prebuild-linux-arm npm script, which I'm hoping will add the ARMv6 prebuild the next time it's run. I tried installing via `npm install` to run the script, but ended up bumping into some node-gyp errors that stopped me from testing this commit locally.
vweevers
approved these changes
Feb 19, 2020
Member
vweevers
left a comment
There was a problem hiding this comment.
I tested it locally, it builds.
Contributor
Author
|
Great, thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem: Leveldown takes a long time to build on low-end devices like
the Pi Zero, and it would be really cool to add a prebuild for ARMv6.
Solution: I've added a Docker image in the prebuild/docker-images
repository and added ARMv6 to the prebuild-linux-arm npm script, which
I'm hoping will add the ARMv6 prebuild the next time it's run. I tried
installing via
npm installto run the script, but ended up bumpinginto some node-gyp errors that stopped me from testing this commit
locally.
Resolves #703