This repository was archived by the owner on Dec 2, 2024. It is now read-only.
Merged
Conversation
juanpicado
commented
Apr 19, 2021
juanpicado
commented
Apr 19, 2021
juanpicado
commented
Apr 19, 2021
60 tasks
vweevers
reviewed
Apr 19, 2021
Co-authored-by: Vincent Weevers <mail@vincentweevers.nl>
Member
|
We're almost there 😃 To make coverage reports work, can you update the |
juanpicado
commented
Apr 19, 2021
vweevers
approved these changes
Apr 19, 2021
Member
vweevers
left a comment
There was a problem hiding this comment.
Amazing, thank you! I will shortly create a branch (that has access to secrets) so we can see it in action (pun intended).
Contributor
Author
super thanks :) I'll back tomorrow to convert one more. |
Member
|
Tests passed and coverage works: https://app.codecov.io/gh/Level/level-js |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref Level/community#99
Currently are failing due
Sauce Labs credentials are requirederror on my repo.