This repository was archived by the owner on Dec 1, 2024. It is now read-only.
Conversation
An error is now thrown when an iterator is created with one of these options. Ref Level/community#86
83 tasks
ralphtheninja
approved these changes
Apr 5, 2021
Member
ralphtheninja
left a comment
There was a problem hiding this comment.
Just a minor note on self variables.
1b7455a to
8240c24
Compare
So that we can use async generators (in a future release).
And also use it in the test suite.
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR drops support of:
startandend(Remove start & end from range options community#86)This allows us to remove
xtend, use latest dependencies (nyc,sinon,standard) which in turn removes vulnerabilities, and to use async generators (in a future semver-minor PR). Easiest to review commit by commit; do not squash on merge.Ref Level/community#98.
FYI @achingbrain because this slightly delays the release of your #373.