Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to toggle view of hidden files or directories in current directory. Addressing #8.
I was thinking about applying the toggle to the whole tree, but it leads to questions like: "What should the tree look like, when toggling hidden off, when being in a hidden directory? Or in a subdirectory, that's not hidden itself, but who's parent is hidden?" ... etc.
I feel like toggling hidden only for current directory is fine, because you only really want to toggle, when there's a lot of hidden stuff in a current directory, that you don't really care about and it gets in your way (e.g.
~sometimes).As a bonus feature of such an approach - you can toggle off hidden files in some directories, but keep them in others. This might be handy... or confuse you... depends