feat(v2): Grimoire as Skill Forge Engine — integration with skills-master#16
Open
LeoLin990405 wants to merge 3 commits into
Open
feat(v2): Grimoire as Skill Forge Engine — integration with skills-master#16LeoLin990405 wants to merge 3 commits into
LeoLin990405 wants to merge 3 commits into
Conversation
- Add docs/grimoire-as-engine.md (v2 architecture: skill forge engine) - Add scripts/lib/skills-master-categories.sh (11 source-types → 12 skills-master categories mapper) Part of v2 upgrade: position Grimoire as the underlying Skill Forge engine called by skills-master (Skill Strategist) at ~/.claude/skills/skills-master/. Phase 1 deliverables: - ✓ docs/grimoire-as-engine.md (this file) - ✓ scripts/lib/skills-master-categories.sh - ✓ symlink ~/.claude/skills/grimoire → ~/Projects/grimoire-skill (local) - ✓ skills-master/references/workflows/create-skill-via-grimoire.md (manager side) - ✓ skills-master/references/reasoning/grimoire-as-engine.md (manager side) Phase 2-4 TODO: classifier upgrade, input source extension (web/obsidian/ github-repo/audio), README v2 rewrite, make test. Refs: TASK-2026-06-03-005
Phase 2 (Classifier upgrade):
- scripts/lib/source-types.sh: add 3 new source types
(github-repo, obsidian-vault-segment, podcast)
+ classify_source_type heuristic extended (podcast keywords,
github.com / readme detection, /obsidian-vaults/ paths)
+ source_unit_label adds Module / Note / Episode units
Phase 3 (4 new input adapters):
- scripts/source-adapter-webpage.sh: Crawl4AI → r.jina.ai Reader API
(free, no auth) → curl+pandoc → curl+sed fallback chain
- scripts/source-adapter-obsidian.sh: read Obsidian vault folder or
single note; preserves frontmatter + [[wikilinks]]; --max-depth N
- scripts/source-adapter-github-repo.sh: shallow clone + extract
README + SKILL.md + docs/ + top-level structure + CHANGELOG head
- scripts/source-adapter-audio.sh: whisper.cpp (M-series optimized)
→ openai-whisper CLI strategy chain; URL or local file input
- scripts/forge.sh: auto-detect 4 new KINDs (webpage, github-repo,
obsidian-vault, audio); directory input → obsidian-vault;
git@ URLs → github-repo; new ext: .mp3/.m4a/.wav/.flac/.opus/.ogg
Phase 4 (README v2 + tests):
- README.md: prominent v2 section explaining Skill Forge Engine
positioning under skills-master (Skill Strategist), call chain
sequence, backward compatibility statement
- CHANGELOG.md: v2 entries documenting all Phase 2-3 additions
- tests/run.sh: update 'unknown URL rejection' test to expect new
v2 webpage adapter routing (assert kind: webpage)
Tests: 166/166 PASS (was 165 pre-v2)
Refs: TASK-2026-06-03-006
On 2026-06-03 PM, this engine was mounted into the user's local skills-master skill as `forge/engine/`. The standalone `grimoire` skill summoning entry was removed locally; "forge from source" requests now route through skills-master first. This GitHub repo remains canonical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v2 升级:Grimoire 从"PDF → 笔记 + skill pack 工具"升级为 通用 Skill Forge 底层引擎,被
skills-master(Skill Strategist) 作为 manager 调用。Analogy:
grimoire≈ webpack / compiler;skills-master≈ npm / package manager。v2 4 layers
Phase 1 (commit 344b442)
Phase 2 (commit 9008f2d)
Phase 3 (commit 9008f2d) — 4 new input source adapters
Phase 4 (commit 9008f2d)
Tests
✅ `make test` 166 / 166 PASS (was 165 pre-v2)
Backward Compatibility
v1 usage 100% 保留:
skills-master 端配套(在 ~/.claude/skills/skills-master/ 已落地)
后续
Test plan