Skip to content

Added function to handle empty values in the three-way migration#1

Draft
LenHukiro wants to merge 8 commits into
mainfrom
fix-for-issue-#13673
Draft

Added function to handle empty values in the three-way migration#1
LenHukiro wants to merge 8 commits into
mainfrom
fix-for-issue-#13673

Conversation

@LenHukiro

@LenHukiro LenHukiro commented Aug 12, 2025

Copy link
Copy Markdown
Owner

Closes JabRef#13673

I was not sure if i needed to add something to the CHANGELOG.md, but i did just in case.

Steps to test

(on the main branch and this branch)

  1. Open Jabref GUI
  2. Create or import an article with a working DOI(Library-> add entry/ add entry using... or with the web search feature)
  3. Then select the journal entry at the bottom page with a click
  4. Empty the "Year" Textfield in the "Required Fields" Tab
  5. Switch to the General Tab
  6. Input the DOI (If its not already filled)
  7. Click the button "Get bibliographic data from DOI"

The button in the General Tab:
ticket2

The error message before the changes:
Screenshot 2025-08-10 140457

The article with the changes:
Screenshot 2025-08-11 130011

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (if change is visible to the user)
  • Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

There was an error when the year was empty in the comparison, if a value was empty. I've added a check to make sure that the values are not empty before the comparison.
@LenHukiro LenHukiro marked this pull request as ready for review August 12, 2025 15:23
@LenHukiro LenHukiro marked this pull request as draft August 13, 2025 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncaught Exception in ThreeWayMerge dialog when looking up Bibliographic information from DOI

1 participant