Added function to handle empty values in the three-way migration#1
Draft
LenHukiro wants to merge 8 commits into
Draft
Added function to handle empty values in the three-way migration#1LenHukiro wants to merge 8 commits into
LenHukiro wants to merge 8 commits into
Conversation
There was an error when the year was empty in the comparison, if a value was empty. I've added a check to make sure that the values are not empty before the comparison.
update working branch
Edited the comments for the checking of empty year values
Co-authored-by: Houssem Nasri <housi.housi2015@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes JabRef#13673
I was not sure if i needed to add something to the
CHANGELOG.md, but i did just in case.Steps to test
(on the main branch and this branch)
The button in the General Tab:

The error message before the changes:

The article with the changes:

Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)