Merged
Conversation
5169eb8 to
6d29cec
Compare
Member
|
Nice, this is a good idea. So this would replace us directly linking to |
Member
Author
|
My plan is to auto-generate this config documentation as part of the lemmy-docs build, and include it there. Then we can remove all the values and comments from config/config.hjson in the repo root, only leaving whats necessary to make |
6d29cec to
c66a792
Compare
c66a792 to
73483eb
Compare
Nutomic
commented
Oct 5, 2021
Member
Author
|
Upstream release 0.10 is out, so this is ready to merge now. Edit: CI failed because of this: anixe/doku#11 |
dessalines
requested changes
Oct 6, 2021
| #[actix_web::main] | ||
| async fn main() -> Result<(), LemmyError> { | ||
| let args: Vec<String> = env::args().collect(); | ||
| if args.len() == 2 && args[1] == "--print-config-docs" { |
Member
There was a problem hiding this comment.
That's pry better than -h. these aren't command line things anyway.
73483eb to
9177b62
Compare
Member
Author
|
Updated, builds fine on stable locally. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pretty much ready to merge now, only waiting for upstream to make a new release. Output looks like the following, which we can include directly in the documentation. It is json (which is also valid hjson), but I plan to rewrite it to the same format used in our config.hjson (remove commas and quotes, change comments to # etc).