fix: #593 by adding global flag to remove cache#602
fix: #593 by adding global flag to remove cache#602jdneo merged 3 commits intoLeetCode-OpenSource:masterfrom yihong0618:master
Conversation
| public async meetRequirements(context: ExtensionContext): Promise<boolean> { | ||
| const isUserFresh: boolean | undefined = context.globalState.get(globalStateLeetcodeIsUserFresh); | ||
| if (isUserFresh !== false) { | ||
| await this.removeOldCache(); |
There was a problem hiding this comment.
Reuse the command we have?
https://github.com/LeetCode-OpenSource/vscode-leetcode/blob/master/src/extension.ts#L51
There was a problem hiding this comment.
Seems a little different.The command way use leetcode-cli way not delete the whole dir, let me check if it works fine too.
There was a problem hiding this comment.
@jdneo
delete cache only delete the user session but not the plugin.js cache, still have that issue. So I think we can not use it..
There was a problem hiding this comment.
Maybe we need to change the implementation of the command delete cache. Considering that the current implementation does not clean entirely?
There was a problem hiding this comment.
Yes, current one only clean the user info(include session), but we change the delete cache also have one problem beacuse user may have two account one leetcode one leetcode-cn, if we change that. both will clean, but user may only want to clean the current cache.
There was a problem hiding this comment.
I see. So let's keep the implementation. Maybe later we can provide two option in this command. Something like Session and All. Anyway it's not a high priority
src/leetCodeExecutor.ts
Outdated
| public async meetRequirements(): Promise<boolean> { | ||
| public async meetRequirements(context: ExtensionContext): Promise<boolean> { | ||
| const isUserFresh: boolean | undefined = context.globalState.get(globalStateLeetcodeIsUserFresh); | ||
| if (isUserFresh !== false) { |
There was a problem hiding this comment.
if (!isUserFresh)
@jdneo
Seems not the same logic if use if (!isUserFresh)
src/leetCodeExecutor.ts
Outdated
| await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "plugin", "-i", plugin]); | ||
| } | ||
| } | ||
| context.globalState.update(globalStateLeetcodeIsUserFresh, false); |
There was a problem hiding this comment.
In the end of activate() I set it to false, in the first it should be undefined so I use (isUserFresh !== false) logic to check.
There was a problem hiding this comment.
Then instead of calling it isUserFresh, it would be better to call it HasInited IMO. And set it to true at the end of activate()
The aim of that is to avoid the two falsy value undefined and false has two different meanings.
| } | ||
|
|
||
| public async signOut(): Promise<string> { | ||
| return await await this.executeCommandEx(this.nodeExecutable, [await this.getLeetCodeBinaryPath(), "user", "-L"]); |
There was a problem hiding this comment.
It seems that its an old typo so I changed it too, am I right?
src/shared.ts
Outdated
| None = "None", | ||
| } | ||
|
|
||
| export const globalStateLeetcodeHasInited: string = "leetcode.isUserFresh"; |
There was a problem hiding this comment.
Please also change the value. No need to have the prefix globalState I think. Since when you calling the API, that API name already tells it's a global state
No description provided.