Fix LatLng.validate throwing on null instead of returning false#10276
Merged
Conversation
typeof null === 'object', so the object branch reached `'lat' in null` and threw `TypeError: Cannot use 'in' operator to search for 'lat' in null` — asymmetric with `validate(undefined)` which correctly returns false. Guard the object check with `lat !== null`. This also makes `new LatLng(null)` throw the intended descriptive `Invalid LatLng object` error (raised by the constructor's validate call) instead of the opaque internal TypeError.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LatLng.validate(null)throwsTypeError: Cannot use 'in' operator to search for 'lat' in nullinstead of returningfalse.typeof null === 'object'istrue, so the object branch reaches'lat' in nulland throws. This is asymmetric withvalidate(undefined), which correctly returnsfalse. The fix guards the object check withlat !== null.As a side effect,
new LatLng(null)now throws the intended descriptiveInvalid LatLng objecterror (from the constructor'svalidatecall) instead of the opaque internalTypeError.Added a
validatespec covering valid inputs and invalid inputs (undefined/null/'foo'/short array) returningfalsewithout throwing. Thenullcase fails without this fix.