[FIX] Make read_input() more general and also us it in heredoc#301
Merged
[FIX] Make read_input() more general and also us it in heredoc#301
read_input() more general and also us it in heredoc#301Conversation
This allows the tester to also test heredoc.
It now is a more general function and also gets used by heredoc. TODO: I don't know in which header file to put the function prototype.
3135d81 to
37a5a59
Compare
LeaYeh
approved these changes
Apr 3, 2024
Collaborator
Author
|
@LeaYeh Aaah the function prototype wasn’t in any header file yet 😱 |
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will allow the tester to also test heredoc.
Also rename the
shell_structdirectory toshell.Into which header file should we put the function prototype of
read_input()?