[FEAT] Add welcome message after init shell#285
Merged
Conversation
0dfc1b1 to
81243c5
Compare
7b8bedb to
a2adbc3
Compare
Big thanks to Valeria for the pixel art: https://github.com/ValeriaGart
It just moves the existing content upwards and starts the new content from the top of the terminal. `\e[2J` moves the viewable lines out of view. `\e[1;1H` moves the cursor to row 1, column 1. This will give the illusion of clearing the screen, but it's still possible to scroll up to see the previous content.
The images were then converted to characters with a tool called `px2ansi`: https://github.com/Nellousan/px2ansi.git
When defining the `WELCOME_MSG` macro in the Makefile, it simply has to be specified wether it should be defined from the make variable `WELCOME_MSG1` or `WELCOME_MSG2`.
Also rename the previous `WELCOME_MSG` macro to `WELCOME_ART`.
Once the user has seen `Crash` once, they should be able to figure out the symbolic meaning of the wave.
This is to make the edges of the art more obvious. Before it looked like it was cut by the window and you could scroll up to see more, which was misleading.
itislu
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
浪潮
浪潮
浪潮
浪潮
浪潮
浪潮