Skip to content

[FEAT] Add welcome message after init shell#285

Merged
itislu merged 19 commits intomainfrom
feat-welcome-msg
Apr 3, 2024
Merged

[FEAT] Add welcome message after init shell#285
itislu merged 19 commits intomainfrom
feat-welcome-msg

Conversation

@LeaYeh
Copy link
Owner

@LeaYeh LeaYeh commented Mar 24, 2024

  1. 海貝 -> sea shell
    浪潮
  2. 海貝 -> tidal wave
    浪潮
  3. 貝 -> sea wave
  4. -> flood of shells
  5. 貝 -> sea tide
  6. -> crashing wave of shells

@LeaYeh LeaYeh force-pushed the feat-welcome-msg branch from 0dfc1b1 to 81243c5 Compare March 25, 2024 21:59
@LeaYeh LeaYeh requested a review from itislu March 26, 2024 07:34
@itislu itislu force-pushed the feat-welcome-msg branch 2 times, most recently from 7b8bedb to a2adbc3 Compare April 2, 2024 22:15
@itislu itislu linked an issue Apr 2, 2024 that may be closed by this pull request
@itislu itislu added the optional feature Cool but not mandatory feature label Apr 2, 2024
@itislu itislu force-pushed the feat-welcome-msg branch from 269f6e8 to 4774021 Compare April 2, 2024 22:53
@LeaYeh LeaYeh requested review from itislu and removed request for itislu April 3, 2024 07:12
LeaYeh and others added 19 commits April 3, 2024 13:52
Big thanks to Valeria for the pixel art: https://github.com/ValeriaGart
It just moves the existing content upwards and starts the new content from the top of the terminal.

`\e[2J` moves the viewable lines out of view.
`\e[1;1H` moves the cursor to row 1, column 1.

This will give the illusion of clearing the screen, but it's still possible to scroll up to see the previous content.
The images were then converted to characters with a tool called `px2ansi`:
https://github.com/Nellousan/px2ansi.git
When defining the `WELCOME_MSG` macro in the Makefile, it simply has to be specified wether it should be defined from the make variable `WELCOME_MSG1` or `WELCOME_MSG2`.
Also rename the previous `WELCOME_MSG` macro to `WELCOME_ART`.
Once the user has seen `Crash` once, they should be able to figure out the symbolic meaning of the wave.
This is to make the edges of the art more obvious.
Before it looked like it was cut by the window and you could scroll up to see more, which was misleading.
@itislu itislu force-pushed the feat-welcome-msg branch from f3a2861 to 732a931 Compare April 3, 2024 12:01
@itislu itislu merged commit 8b6ae17 into main Apr 3, 2024
@itislu itislu deleted the feat-welcome-msg branch April 3, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

optional feature Cool but not mandatory feature

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[OPTIONAL] Add welcome message/drawing when starting up 🌊rash

2 participants