Skip to content

[FIX] Fix wrong null-expansion after word-splitting and quote combination#283

Merged
LeaYeh merged 6 commits intomainfrom
fix-issue-281
Apr 1, 2024
Merged

[FIX] Fix wrong null-expansion after word-splitting and quote combination#283
LeaYeh merged 6 commits intomainfrom
fix-issue-281

Conversation

@itislu
Copy link
Collaborator

@itislu itislu commented Mar 23, 2024


The issue was caused by too early quote removal.
Now the quotes get removed at the end of the expansion process, as is specified in the GNU Bash manual as well.

  • All expander tasks now have a double pointer to the string saved in the corresponding lst node.
  • Every entry to the expander now gets put into a lst node immediately.

@itislu itislu added the bug Something isn't working label Mar 23, 2024
@itislu itislu added this to the Expander milestone Mar 23, 2024
@itislu itislu assigned LeaYeh and unassigned LeaYeh Mar 23, 2024
@itislu itislu force-pushed the fix-issue-281 branch 6 times, most recently from 3049418 to f8ee638 Compare March 26, 2024 00:45
@itislu itislu force-pushed the fix-issue-281 branch 2 times, most recently from 4d2ecec to a7f63a0 Compare March 27, 2024 11:42
itislu added 6 commits April 1, 2024 13:40
It was caused by too early quote quote_removal.
Now the quotes get removed at the end of the expansion process, as is specified in the GNU Bash manual as well.

- All expander tasks now have a double pointer to the string saved in the corresponding lst-node.
- Every entry to the expander now gets put into a lst-node immediately.

* Resolves #281
Also slightly reduce amount of whitespace in Makefile.
@LeaYeh LeaYeh merged commit e1abc36 into main Apr 1, 2024
@LeaYeh LeaYeh deleted the fix-issue-281 branch April 1, 2024 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[BUG] Wrong null-expansion after word-splitting and quote combination

2 participants