[CHORE] Avoid misleading ft_free_and_null()s#279
Merged
Conversation
All the calls to ft_free_and_null would just set the local pointer of the freeing function to NULL. This might give a false sense of safety that the pointer that gets put as an argument also gets set to NULL.
22f6e2e to
e95be6d
Compare
LeaYeh
approved these changes
Mar 24, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All the calls to
ft_free_and_null()would just set the local pointer of the freeing function to NULL.This might give a false sense of safety that the pointer that gets put as an argument also gets set to NULL.
This new PR only changes those
ft_free_and_null()s back tofree()that make no difference to signal interrupt behavior.