Skip to content

Fix Blob and URL creation behaviour#105

Merged
weizman merged 1 commit intomainfrom
fix-some-issues-with-url-creation-and-blobs
Jun 20, 2023
Merged

Fix Blob and URL creation behaviour#105
weizman merged 1 commit intomainfrom
fix-some-issues-with-url-creation-and-blobs

Conversation

@weizman
Copy link
Copy Markdown
Member

@weizman weizman commented Jun 20, 2023

Continuing #88 where a bug was introduces, here are the essence of the changes:

  • On Figma I learned that sometimes websites create blobs with no type ("") so added that as legit blob type
  • Also there's a new behaviour in Chrome where creating a URL out of a blob where the URL object belongs to a no longer attached realm returns "" instead of a legit blob url, so i fixed that to make sure URL creation is executed against the top main realm
  • Added a test to make sure blob with no type cannot be used as html to bypass snow

@weizman weizman merged commit cde5ac2 into main Jun 20, 2023
@weizman weizman deleted the fix-some-issues-with-url-creation-and-blobs branch June 20, 2023 13:17
@weizman weizman mentioned this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant