Skip to content

Support Node.js v20#718

Merged
legobeat merged 1 commit into
LavaMoat:mainfrom
legobeat:node-20
Sep 14, 2023
Merged

Support Node.js v20#718
legobeat merged 1 commit into
LavaMoat:mainfrom
legobeat:node-20

Conversation

@legobeat

Copy link
Copy Markdown
Collaborator

No description provided.

@legobeat legobeat mentioned this pull request Sep 14, 2023
@legobeat legobeat requested a review from a team September 14, 2023 07:52
@legobeat legobeat force-pushed the node-20 branch 6 times, most recently from 8109448 to f5788c1 Compare September 14, 2023 07:58
@legobeat legobeat marked this pull request as ready for review September 14, 2023 08:05

@boneskull boneskull left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

^14.0.0 || ^16.0.0 || ^18.0.0 || ^20.0.0 might be safer, since we don't test on any odd-numbered versions (all of them EOL'd) at all, but that could be considered breaking, so 🤷

@legobeat

legobeat commented Sep 14, 2023

Copy link
Copy Markdown
Collaborator Author

^14.0.0 || ^16.0.0 || ^18.0.0 || ^20.0.0 might be safer, since we don't test on any odd-numbered versions (all of them EOL'd) at all, but that could be considered breaking, so 🤷

@boneskull Yes, my thinking is that this default range makes sense (also getting on top of language features added during supported maintenance LTSs):

^16.20 || ^18.16 || >=20

or even (requiring explicit support signalling for future major node versions)

^16.20 || ^18.16 || ^20

But as you say, breaking either way and I'm thinking it would be nice to push out Node 20 support in a non-breaking release and then follow up with breaking runtimes as the next step and see which runtime versions make sense to keep support for separate from this PR.

@legobeat legobeat merged commit ef3a0da into LavaMoat:main Sep 14, 2023
@legobeat legobeat deleted the node-20 branch October 1, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants