Skip to content

core: internal refactor scuttling options handling#597

Closed
legobeat wants to merge 3 commits into
LavaMoat:snow-scuttling-integrationfrom
legobeat:lgbt/snow-scuttling-integration-refactor-opts-core
Closed

core: internal refactor scuttling options handling#597
legobeat wants to merge 3 commits into
LavaMoat:snow-scuttling-integrationfrom
legobeat:lgbt/snow-scuttling-integration-refactor-opts-core

Conversation

@legobeat

@legobeat legobeat commented May 29, 2023 •
edited
Loading

Copy link
Copy Markdown
Collaborator
  • reduce transient state
  • scuttle
  • various internal function renames
  • add validation of scuttleGlobalThis.exceptions

@legobeat legobeat requested a review from weizman May 29, 2023 13:36
@legobeat legobeat force-pushed the lgbt/snow-scuttling-integration-refactor-opts-core branch 2 times, most recently from 6114e64 to 44c452d Compare May 29, 2023 13:50
legobeat
legobeat commented May 29, 2023
View reviewed changes
Comment thread packages/core/src/kernelCoreTemplate.js
legobeat
legobeat commented May 29, 2023
View reviewed changes
Comment thread packages/core/src/kernelCoreTemplate.js
legobeat
legobeat commented May 29, 2023
View reviewed changes
Comment thread packages/core/src/kernelCoreTemplate.js
legobeat
legobeat commented May 29, 2023
View reviewed changes
Comment thread packages/core/src/kernelCoreTemplate.js
legobeat
legobeat commented May 29, 2023
View reviewed changes
Comment thread packages/core/src/kernelCoreTemplate.js
legobeat
legobeat commented May 29, 2023
View reviewed changes
Comment thread packages/core/src/kernelCoreTemplate.js
@legobeat legobeat force-pushed the lgbt/snow-scuttling-integration-refactor-opts-core branch 2 times, most recently from 4524ce8 to 4df218a Compare May 29, 2023 14:47
@legobeat
core: internal refactor generateKernel
e2258c6 
- reduce transient state
- transform all scuttle exceptions to regexps internally
- various internal function renames
@legobeat legobeat force-pushed the lgbt/snow-scuttling-integration-refactor-opts-core branch from 4df218a to e2258c6 Compare May 29, 2023 14:51
@legobeat legobeat marked this pull request as ready for review May 29, 2023 14:52
@legobeat legobeat mentioned this pull request May 29, 2023
Merged
@legobeat
don't trust input value for determining string/regexp handling
a6d1662 
track original type and always eventually convert to regexp in order to minimize branching
@legobeat legobeat force-pushed the lgbt/snow-scuttling-integration-refactor-opts-core branch from 3ef41a9 to a6d1662 Compare May 29, 2023 15:41
@weizman weizman deleted the branch LavaMoat:snow-scuttling-integration June 14, 2023 08:14
@weizman weizman closed this Jun 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weizman weizman Awaiting requested review from weizman

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@legobeat @weizman