Skip to content

deps: bump core deps and devDeps#572

Merged
legobeat merged 4 commits into
LavaMoat:mainfrom
legobeat:deps-core
May 16, 2023
Merged

deps: bump core deps and devDeps#572
legobeat merged 4 commits into
LavaMoat:mainfrom
legobeat:deps-core

Conversation

@legobeat

Copy link
Copy Markdown
Collaborator
  • core/deps: merge-deep@^3.0.2->^3.0.3
  • core/deps: json-stable-stringify@^1.0.1->^1.0.2
  • core/devDeps: ses@^0.17.0->^0.18.4
    • Note: Prior to this change, users respecting thelockfile actually end upwith two different versions of ses, where core was on the older 0.17.0.
  • core/devDeps: tmp-promise@^3.0.2->^3.0.3

@legobeat legobeat added the dependencies Pull requests that update a dependency file label May 13, 2023
@legobeat

legobeat commented May 13, 2023

Copy link
Copy Markdown
Collaborator Author

Poll! 🙋

How granular do you like our git log to be? Vote by reacting.

  • 🎉 to keep these commits independent on merge
  • 🚀 to squash these into a single commit on merge
  • 😕 other. leave comment.
  • 😄 i don't care, i just like reacting to things, also hi lego

@legobeat legobeat requested a review from a team May 13, 2023 05:33
@legobeat legobeat marked this pull request as ready for review May 13, 2023 05:35
@legobeat legobeat requested review from leotm, naugtur and weizman May 15, 2023 05:49
@legobeat legobeat merged commit 6abe05c into LavaMoat:main May 16, 2023
@weizman

weizman commented May 16, 2023

Copy link
Copy Markdown
Member

Does this mean PR squashing from now on? 😍

@legobeat

legobeat commented May 16, 2023

Copy link
Copy Markdown
Collaborator Author

@weizman "these commits" here would refer to specifically this situation. It would still be on a case-by-case basis and this is one step on figuring out where to draw the line (in this case I merged them independently but would first squash into 1-3 before doing a rebase-merge in a future identical situation).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants