Skip to content

refactor scuttler opts generation#482

Merged
weizman merged 2 commits into
snow-scuttling-integration-propose-scuttlerfrom
snow-scuttling-integration-propose-scuttler-refactor-opts-gen
May 24, 2023
Merged

refactor scuttler opts generation#482
weizman merged 2 commits into
snow-scuttling-integration-propose-scuttlerfrom
snow-scuttling-integration-propose-scuttler-refactor-opts-gen

Conversation

@weizman

@weizman weizman commented Apr 20, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

have in a single function that properly makes sure that:

  • scuttle conf is regenerated into a new object to avoid mutating the original opts obj
  • handle "enabled-by-default" where scuttleOpts === true
  • set scuttlerFunc
  • throw if scuttlerName is set but does not appear on globalRef

(ctx #475 (comment))

@weizman weizman mentioned this pull request Apr 20, 2023
Merged
3 tasks
@weizman weizman requested a review from legobeat April 24, 2023 12:33
@weizman weizman marked this pull request as ready for review May 3, 2023 15:38
leotm
leotm reviewed May 23, 2023
View reviewed changes
Comment thread packages/lavapack/src/runtime.js
@weizman weizman mentioned this pull request May 24, 2023
Merged
@weizman weizman merged commit f841974 into snow-scuttling-integration-propose-scuttler May 24, 2023
@weizman weizman deleted the snow-scuttling-integration-propose-scuttler-refactor-opts-gen branch May 24, 2023 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leotm leotm leotm left review comments

@legobeat legobeat Awaiting requested review from legobeat

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@weizman @leotm