Skip to content

chore: update lockfile#1721

Merged
boneskull merged 3 commits into
mainfrom
leotm/update-lockfile
Jun 24, 2025
Merged

chore: update lockfile#1721
boneskull merged 3 commits into
mainfrom
leotm/update-lockfile

Conversation

@leotm

@leotm leotm commented Jun 24, 2025

Copy link
Copy Markdown
Member

@leotm leotm changed the title Leotm/update lockfile chore: update lockfile Jun 24, 2025
@leotm leotm marked this pull request as ready for review June 24, 2025 18:07
@leotm leotm mentioned this pull request Jun 24, 2025
@naugtur

naugtur commented Jun 24, 2025

Copy link
Copy Markdown
Member

Wait, why do we depend on pbkdf2? Must be in an example somewhere, maybe perf. Right?

@boneskull

Copy link
Copy Markdown
Member

It's in crypto-browserify.

@naugtur

naugtur commented Jun 24, 2025

Copy link
Copy Markdown
Member

OK, so not affecting anything. But still good for the posture.

@boneskull

Copy link
Copy Markdown
Member

We had a problem running npm dedupe before, but I suppose as long as npm ls does not report problems, we should be OK (this is run via lint:lockfile as part of CI)

@naugtur

naugtur commented Jun 24, 2025

Copy link
Copy Markdown
Member

Anything else pending for the release?

@boneskull boneskull merged commit ae5497d into main Jun 24, 2025
16 checks passed
@boneskull boneskull deleted the leotm/update-lockfile branch June 24, 2025 19:54
@boneskull

Copy link
Copy Markdown
Member

@naugtur I don't think there's anything urgent

@naugtur

naugtur commented Jun 24, 2025

Copy link
Copy Markdown
Member

Feel free to crank it out or I'll do it tomorrow

@boneskull

Copy link
Copy Markdown
Member

@naugtur I'll do it

@boneskull

boneskull commented Jun 24, 2025

Copy link
Copy Markdown
Member

OK, I cut a release.

@naugtur The flaky symlink test was failing for me locally.

@leotm See #1723

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants