feat: @lavamoat/react-native-lockdown#1438
Merged
Merged
Conversation
28 tasks
leotm
commented
Feb 18, 2025
leotm
commented
Feb 18, 2025
leotm
commented
Mar 25, 2025
leotm
commented
Mar 26, 2025
07f580a to
299ba72
Compare
leotm
commented
Mar 28, 2025
9426cb3 to
e5401c3
Compare
leotm
commented
Mar 28, 2025
leotm
commented
Mar 28, 2025
leotm
commented
Mar 28, 2025
e5401c3 to
b119fac
Compare
leotm
commented
Mar 28, 2025
leotm
commented
Mar 28, 2025
b119fac to
c3521cb
Compare
leotm
commented
Mar 28, 2025
c3521cb to
26d1e4e
Compare
leotm
commented
Mar 31, 2025
leotm
commented
Mar 31, 2025
26d1e4e to
81275cf
Compare
leotm
commented
Mar 31, 2025
leotm
commented
Mar 31, 2025
1191499 to
e0f0782
Compare
leotm
commented
May 30, 2025
b65aac8 to
5f93583
Compare
leotm
added a commit
that referenced
this pull request
Jun 3, 2025
f41f7a8 to
77534c4
Compare
naugtur
reviewed
Jun 6, 2025
naugtur
approved these changes
Jun 6, 2025
leotm
commented
Jun 6, 2025
boneskull
approved these changes
Jun 6, 2025
boneskull
left a comment
Member
There was a problem hiding this comment.
I don't have any blockers, but some more suggestions / questions.
Member
Author
|
tested packed in metamask-mobile, 120 commit rebase inc, follow-ups noted in description |
Member
|
@leotm I'll let you squash this mofo |
leotm
added a commit
that referenced
this pull request
Jun 10, 2025
033deac to
d96574c
Compare
leotm
commented
Jun 10, 2025
Co-authored-by: naugtur <naugtur@gmail.com> Co-authored-by: Christopher Hiller <boneskull@boneskull.com>
044c951 to
c66feb0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New package
React Native app init order
Metro
(user ignores SES shim with babel)
Hermes https://github.com/facebook/hermes/blob/main/utils/promise/index.js
RN https://github.com/facebook/react-native/blob/main/packages/react-native/Libraries/Core/polyfillPromise.js
SES removes https://github.com/then/promise/blob/master/src/core.js#L68-L70
(https://github.com/then/promise/blob/master/src/es6-extensions.js requires)
so we add them back as vetted shims after repair
https://github.com/facebook/react-native/blob/main/packages/community-cli-plugin/src/utils/loadMetroConfig.js#L59-L76
https://github.com/facebook/react-native/blob/main/packages/metro-config/src/index.flow.js#L61-L73
Follow-up with e2e test
Follow-up ship type declarations
Follow-up extend assertPolyfills
Follow-up node/macOS CI failures (unrelated to this PR)
Follow-up update upstream template metro.config.js to modern TS
@importFollow-up maybe another refactor
Follow-up update all /packages
LICENSE.md->LICENSEand add one for laverna