Fix race condition in ConfigInvalidation.setup() with Promise-based init #13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ConfigInvalidation.setup()function used a module-level boolean flag to prevent duplicate subscriptions, creating a race condition when called concurrently—multiple calls could pass the check before any set the flag.Changes:
initializedboolean withsetupPromise: Promise<void> | undefinedsetup()async, returning the stored Promise on subsequent callsConfigInvalidation.setup()inInstanceBootstrap()Before:
After:
Concurrent calls now await the same initialization Promise, ensuring exactly-once setup.
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.