fix: security hardening — TLS production guard, PII log removal, URL sanitization#215
Merged
LarytheLord merged 1 commit intomainfrom May 5, 2026
Merged
fix: security hardening — TLS production guard, PII log removal, URL sanitization#215LarytheLord merged 1 commit intomainfrom
LarytheLord merged 1 commit intomainfrom
Conversation
…itization - send-email: TLS insecure override now blocked in production (SMTP_TLS_INSECURE can only activate in non-production environments) - forgot-password: remove email address from dev-mode console.log (PII leak) - middleware: log only pathname, not full URL (query params can contain tokens) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three targeted security fixes from desloppify scan (HIGH + MEDIUM findings):
SMTP_TLS_INSECURE=truenow only activates outside production — prevents misconfiguration from disabling TLS verification in live environmentsforgot-passwordroute even with dev guard — removed entirelyrequest.url(could expose tokens in query params) — now logs onlypathnameWhat was suppressed as false positive
chart.tsxdangerouslySetInnerHTML— shadcn internal CSS var injection, not user inputseed.tshardcoded password — dev-only, never reaches productionrazorpay/webhookerror log — logs key name absence, not the key valuereset-passworderror log — generic Error object, no PII on error pathlib/auth.tsemail log — dev-only guard, acceptable for local debuggingTest plan
npm run lint— 0 errorsnpm run type-check— 0 errorsnpm run build— cleanSMTP_TLS_INSECURE=trueSMTP_TLS_INSECURE=truewhenNODE_ENV=production🤖 Generated with Claude Code