Use rocm_check_target_ids if available#1
Merged
LakshmiKumar23 merged 1 commit intoLakshmiKumar23:lk/gfx_updatefrom Feb 21, 2025
Merged
Use rocm_check_target_ids if available#1LakshmiKumar23 merged 1 commit intoLakshmiKumar23:lk/gfx_updatefrom
LakshmiKumar23 merged 1 commit intoLakshmiKumar23:lk/gfx_updatefrom
Conversation
LakshmiKumar23
approved these changes
Feb 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When setting the default GPU targets, this change causes rpp to use
rocm_check_target_idsfrom rocm-cmake-build-tools (aka rocm-cmake), if it is available. Any targets from gfx942 and newer are checked with using a call tocheck_cxx_compiler_flagto verify that the compiler supports them, before they're added to the default GPU targets list.This check is skipped if the user specifies a GPU target list, or if
rocm_check_target_idsis not available at build time.