Conversation
…hape/shot noise terms to benchamrk calculations. Removed redundant calculations and added some additional unit tests to catch warnings.
…d FKEM to cache cosmo object and to test individual tracer combinations for "auto" setting instead of total combination.
|
@damonge, moving |
carlosggarcia
left a comment
There was a problem hiding this comment.
Great work. Some comments/questions to address while we decide what we do with the (private) API change.
Pull Request Test Coverage Report for Build 22635547529Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
|
@carlosggarcia I wouldn't worry about that kind of API breakage, to be honest. Not worth wasting time on that. Is the idea that we will want to implement other non-Limber methods? |
|
Ok. So let's merge it. Yes, the idea behind this change of structure is to leave room for new non-limber methods. @nikosarcevic and @paulrogozenski can say more. |
|
For the record. I forgot to mark it as approved it but I approved it. Also, the errors were due to being too slow to push to coveralls, which had already sent a report back for those jobs that had already finished. And the lower coverage I believe it was due to a misestimation due to merging main, instead of rebasing. |
Refactor of FKEM Non-Limber algorithm, aimed at