Merged
Conversation
Pull Request Test Coverage Report for Build 20566624524Details
💛 - Coveralls |
damonge
approved these changes
Jan 14, 2026
Collaborator
damonge
left a comment
There was a problem hiding this comment.
I like this (better than modifying setup.py). TBH, I'm also fine with just dropping all the C-level tests altogether, since we do not claim to support the C API. Just saying this in case it becomes a nuisance in the future.
Collaborator
Author
|
Thanks, I'll have that in mind. Merging now! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have added a new step to the CI to make all the targets in the Makefile, including the C-level benchmarks that are currently not being run.
Alternatively, one could replace
_ccllibforallinsetup.py:CCL/setup.py
Line 23 in 056ae62
@damonge, thoughts?