Adding large scale extrapolation of HEFT power spectra with biased li…#1249
Merged
Adding large scale extrapolation of HEFT power spectra with biased li…#1249
Conversation
…near matter power spectrum.
Pull Request Test Coverage Report for Build 15870931908Details
💛 - Coveralls |
damonge
requested changes
Jun 23, 2025
Collaborator
damonge
left a comment
There was a problem hiding this comment.
Looks good! Just minor comments below, and a less minor one here: could we add a unit test checking that the extrapolation is doing the right thing? I.e. call bacco without extrapolation and then check that at k=1E-4 or whatever it matches the linear prediction.
Contributor
Author
|
Thank you so much for the review @damonge! Should all be addressed in the new commit but do let me know about the encasing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds extrapolation of the BACCO HEFT power spectra at large scales with the appropriately biased linear power spectrum from baccoemu. This is to avoid extrapolation issues that happen when extrapolating outside the k range covered by the BACCO HEFT emulator.