fixing normalisation issue of trispectrum in halomodel#1248
Merged
Conversation
Pull Request Test Coverage Report for Build 15541749559Details
💛 - Coveralls |
carlosggarcia
approved these changes
Jun 9, 2025
Collaborator
carlosggarcia
left a comment
There was a problem hiding this comment.
Good catch!
LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There existed an issue of the amplitude of the trispectrum for the case of
matter, matter, HOD, matter(found by Davide Sciotti), giving way too large values for the trispectrum in that case.Reason:
_get_normsassigned a wrong norm in this case. In particular, the code asks if profile_1 and profile_4 are the same but assigns norm_4 to norm_3 instead of norm_1. Due to the structure of thematter, matter, HOD, matter, this would assign the HOD norm twice in this case.After the fix, the amplitudes of the trispectra are consistent.