fixed the build dependencies to include numpy#1208
Closed
James11222 wants to merge 1 commit intoLSSTDESC:masterfrom
Closed
fixed the build dependencies to include numpy#1208James11222 wants to merge 1 commit intoLSSTDESC:masterfrom
James11222 wants to merge 1 commit intoLSSTDESC:masterfrom
Conversation
By including numpy as a build dependency, this fixes build installation issues through the pip and uv.
Collaborator
|
@James11222 you'll need to merge the latest version of master for the tests to pass. Unless you want to close this and I'll open a PR with your modification. |
Merged
|
I'd recommend checking the somewhat poorly named "Always suggest updating pull request branches" in the repo settings. That will add a little button that can be used to merge or rebase with a single click. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By including numpy as a build dependency, this fixes build installation issues through the pip and uv.
This fixes isolated installs with pip.
@henryiii helped me figure out this fix!
This should fix #1180