Merged
Conversation
Pull Request Test Coverage Report for Build 9017026807Details
💛 - Coveralls |
Contributor
Author
|
Somehow this PR also fixes unit tests on macOS. |
Contributor
Author
|
To suppress other warnings, we should turn to PR #1144, which I think is ready for review. |
Collaborator
|
@hsinfan1996 thanks for this. #1144 is merged, and I can review this as soon as conflicts are resolved. |
Contributor
Author
|
I was going to make this PR a final fix to setup.py before we merge PR #1144. But it is still good to just fix the unit tests on macOS. |
Contributor
Author
|
@damonge Thank you. This PR is ready for review. For the changes in |
damonge
approved these changes
May 9, 2024
Collaborator
damonge
left a comment
There was a problem hiding this comment.
LGTM! Thanks a lot @hsinfan1996
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a warning on ambiguous package distribution. (Installing with develop mode "-e" will not see the warning.)