Skip to content

Inconsistent naming of baccoemu baryons object#1172

Merged
damonge merged 4 commits intomasterfrom
inconsistent-naming-of-baccoemu-baryons-object
May 1, 2024
Merged

Inconsistent naming of baccoemu baryons object#1172
damonge merged 4 commits intomasterfrom
inconsistent-naming-of-baccoemu-baryons-object

Conversation

@zdu863
Copy link
Contributor

@zdu863 zdu863 commented Mar 27, 2024

  1. Renamed BaccoemuBaryons class to BaryonsBaccoemu.
  2. Created a deprecated class BaccoemuBaryons that will generate a deprecation warning when called.

@zdu863 zdu863 linked an issue Mar 27, 2024 that may be closed by this pull request
@zdu863 zdu863 requested a review from damonge March 27, 2024 14:42
@coveralls
Copy link

coveralls commented Mar 27, 2024

Pull Request Test Coverage Report for Build 8459738288

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.03%) to 97.456%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pyccl/baryons/baccoemu_baryons.py 8 10 80.0%
Totals Coverage Status
Change from base Build 8354757719: -0.03%
Covered Lines: 6552
Relevant Lines: 6723

💛 - Coveralls

@zdu863 zdu863 requested a review from elisachisari March 27, 2024 15:44
Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really great, thanks @zdu863 ! Just one comment and we can merge.

Copy link
Collaborator

@damonge damonge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@damonge damonge merged commit 6347934 into master May 1, 2024
@damonge damonge deleted the inconsistent-naming-of-baccoemu-baryons-object branch May 1, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent naming of BaccoEmu Baryons object

3 participants