Conversation
Pull Request Test Coverage Report for Build 8048774551Details
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a
Cosmology.to_dictmethod and addresses #1159, as well as #1150. It allows round-tripping, even when the arguments are complex types:Currently this dumps everything into the yaml file when callingwrite_yaml, which can be quite awkward for all the internal data of the emulators. The upside is that the write/read yaml works for round trips but I think throwing an error until we have a cleaner solution for yaml serialisation for complex types might be cleaner.Now raises an error when trying to use
write_yamlwith complex types.