Conversation
Pull Request Test Coverage Report for Build 7915493120Details
💛 - Coveralls |
c6e4178 to
c200f9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a quick fix for the aborts reported in #1129 by moving the call to disable the GSL error handling from
ccl_parameters_createtoccl_cosmology_create.This uncovered a bunch of other issues though. From the python side,
ccl_parameters_createisn't being used any more.It is still used from within the C code though, mainly in halofit and the mu-Sigma MG stuff. So now there are two places in the code that deal with the non-trivial aspects of the
ccl_parametersstruct, namely the allocation of the massive neutrino arrays and MG arrays.Speaking of these arrays, right now you can do some pretty nasty stuff by accessing arbitrary memory because
N_nu_masscan be changed from python. I added a fix for one memory leak but there might be others.gives
I'm aware that
_paramsis supposed to be private but it shouldn't be that easy to mess with C memory.