Merged
Conversation
Pull Request Test Coverage Report for Build 7019989337
💛 - Coveralls |
damonge
requested changes
Nov 24, 2023
Collaborator
damonge
left a comment
There was a problem hiding this comment.
Awesome, thanks a lot @matteozennaro ! Only 2 small comments.
Collaborator
|
I approved, so feel free to merge, however, one extra comment in case you'd like to address it: to a non-expert, it won't be clear what this new class does that is different from the velocileptors-based calculator. You don't have to use HEFT ;-), but perhaps worth saying something about how this methodology is different from LPT? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of the nonlinear galaxy bias prescription as in the hybrid Lagrangian bias expansion from the baccoemu emulator library. Followed closely the structure and conventions of the lpt module.