DarkEmulator HaloMassFunction#1138
Merged
KeitaroIshikawa merged 22 commits intomasterfrom Jul 12, 2024
Merged
Conversation
Pull Request Test Coverage Report for Build 9905945849Details
💛 - Coveralls |
Contributor
Author
|
I have just added a benchmark test for the Dark Emulator halo mass function (test_nishimichi19_hmf.py, hmf_nishimichi19.txt). |
….yml and updated readthedocs
HironaoMiyatake
approved these changes
Jul 9, 2024
damonge
reviewed
Jul 12, 2024
Collaborator
damonge
left a comment
There was a problem hiding this comment.
Just a couple final comments.
damonge
approved these changes
Jul 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have implemented halo mass function calculated by Dark Emulator (Nishimichi et al. 2019).
The file name is nishimichi19.py.
Accordingly, import statement is also added into init.py file in hmfunc directory.
Any comments or questions are welcome.