Skip to content

Why do we use normprof? #985

@nikfilippas

Description

@nikfilippas

I don't think it is a good design choice to have to pass all the profiles and their corresponding normprof arguments in the entire halos subpackage. In practice, the profiles are either always normalized, or they aren't, for the life of the HaloProfile instance. A better design choice is to have normprof as an attribute of each profile. These can be preset, but we may give the option to users to change it if needed (even though I doubt it will ever need to change). At the end of the day, normprof has to do with an individual profile, so it makes sense for it to be an attribute of that profile.

Currently, users have to keep track of all the profiles and their normprofs with their respective numbers (normprof1, normprof2, ...) which is not only tedious, but can also be error prone.

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions