This repository was archived by the owner on Jul 9, 2025. It is now read-only.
Update create_new to create for zsh config#45
Merged
Conversation
|
LGTM! |
Contributor
Author
|
@OverHash Have you built and tested it to see if this works for you with zsh? That would be very helpful for me. |
|
Yep, looks like the correct behavior now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #44 by changing
create_newtocreate.It seems like when for zsh only previously it was attempting to create a new file, but when the file already existed it fails with an
AlreadyExistserror as it attempts to open when the file exists.This is hard for me to test since I don't use zsh myself, I only encountered this helping others.