Skip to content
This repository was archived by the owner on Jul 9, 2025. It is now read-only.

Support self-install on Unix#12

Closed
Yumacide wants to merge 2 commits into
LPGhatguy:mainfrom
Yumacide:main
Closed

Support self-install on Unix#12
Yumacide wants to merge 2 commits into
LPGhatguy:mainfrom
Yumacide:main

Conversation

@Yumacide

@Yumacide Yumacide commented May 24, 2022

Copy link
Copy Markdown
Contributor

Closes #10.

@LPGhatguy

Copy link
Copy Markdown
Owner

I updated your description, but you need to put closing keywords in the main description in order for GitHub to pick them up. You can edit your PR at any time!

@LPGhatguy

Copy link
Copy Markdown
Owner

This PR appears to be taken verbatim from the Rustup source code. In the future, when contributing PRs to any project, you should include attribution for code that you did not write both in your PR body and in the source code, following the original code's license.

The upstream project, Rustup, is dual-licensed under the MIT and Apache-2.0 licenses. While it is possible to attribute this code to them and include an exception that some code in Aftman is owned by the authors of Rustup, I would rather keep this entire project under the same license.

@Yumacide

Copy link
Copy Markdown
Contributor Author

Rustup's README says: "Licensed under either of Apache 2.0 or MIT at your option." so you can keep the MIT license, but I should indeed have added some attribution. Thanks!

@LPGhatguy

Copy link
Copy Markdown
Owner

Keeping the MIT license is one thing, but I would like to keep all of the code under this project under the same copyright notice without additional attribution or asterisks. Instead of taking this code wholesale from Rustup, I would rather we write a simpler solution that fits in with the codebase and stays owned solely by Aftman contributors.

@LPGhatguy

Copy link
Copy Markdown
Owner

Replaced by #16.

@LPGhatguy LPGhatguy closed this Jul 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Supporting adding to PATH on non-Windows platforms

2 participants