Merged
Conversation
6 tasks
CohenCyril
reviewed
Mar 27, 2022
Makefile
Outdated
| COQDOCINSTALL ?= $(DESTDIR)$(DOCDIR)/user-contrib | ||
|
|
||
| export DESTDIR | ||
| #export DESTDIR |
Collaborator
There was a problem hiding this comment.
Ahah yes, srry, but I think this is not the right fix. I think the split between DESTDIR and DOCDIR was wrong...
Is it supposed to be
DESTDIR ?= $(shell $(COQBIN)/coqc -where)/../
DOCDIR ?= ../share/doc/coq-elpi/
maybe?
CC @gares
Contributor
Author
|
Is there a difference between |
Contributor
|
I don't think there is any. But when we did that change we had an extra |
Collaborator
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be merged in sync with the upstream PR rocq-prover/rocq#15693
I had to comment a line in the Makefile for the installation to work properly in the CI of Coq