Skip to content

[CI] fix blend-server venv #3099

Merged
ApostaC merged 3 commits intoLMCache:devfrom
deng451e:fix/ci_blend_test
Apr 22, 2026
Merged

[CI] fix blend-server venv #3099
ApostaC merged 3 commits intoLMCache:devfrom
deng451e:fix/ci_blend_test

Conversation

@deng451e
Copy link
Copy Markdown
Collaborator

@deng451e deng451e commented Apr 22, 2026

What this PR does / why we need it:

Special notes for your reviewers:

If applicable:

  • this PR contains user facing changes - docs added
  • this PR contains unit tests

Note

Medium Risk
Moderate risk because it changes CI dependency resolution (drops explicit torch pin) and the runtime environment used to launch the blend server, which could surface version/compatibility issues during integration runs.

Overview
Runs the LMCache blend server using the nightly/test venv (TEST_PYTHON) instead of the default image venv, aligning the blend test components with the intended vLLM/LMCache environment.

Updates the blend CI environment setup to install nightly vllm without an explicit torch==... pin, and enhances the blend test harness to write per-process logs under a repo-root logs_<BUILD_ID>/ directory (with a merged artifact still produced for CI).

Wires RequestType.REPORT_BLOCK_ALLOCATION into blend_server_v2 (handler registration + normal thread pool) so observability reports are accepted by the blend server.

Reviewed by Cursor Bugbot for commit a96556c. Bugbot is set up for automated code reviews on this repo. Configure here.

Signed-off-by: deng451e <838677410@qq.com>
Copy link
Copy Markdown

@cursor cursor Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit ea9f10a. Configure here.

Comment thread lmcache/v1/multiprocess/blend_server_v2.py Outdated
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the CI environment by relocating logs to the repository root for better visibility and adjusting the Python execution environment for the blend server. It also introduces a handler for REPORT_BLOCK_ALLOCATION requests. A review comment identifies that this request type is incorrectly assigned to the affinity thread pool; it should be moved to the normal thread pool to avoid consuming resources intended for GPU-bound tasks and to ensure architectural consistency.

Comment thread lmcache/v1/multiprocess/blend_server_v2.py Outdated
Signed-off-by: deng451e <838677410@qq.com>
Copy link
Copy Markdown
Contributor

@ApostaC ApostaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ApostaC ApostaC enabled auto-merge (squash) April 22, 2026 01:28
@github-actions github-actions Bot added the full Run comprehensive tests on this PR label Apr 22, 2026
Copy link
Copy Markdown
Contributor

@sammshen sammshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ApostaC ApostaC merged commit f0b8610 into LMCache:dev Apr 22, 2026
53 of 54 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full Run comprehensive tests on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants