[CI] add missing egress endpoints to nightly Docker build#3087
Merged
ApostaC merged 1 commit intoLMCache:devfrom Apr 21, 2026
Merged
[CI] add missing egress endpoints to nightly Docker build#3087ApostaC merged 1 commit intoLMCache:devfrom
ApostaC merged 1 commit intoLMCache:devfrom
Conversation
Contributor
|
Note Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly Docker image build was failing because the harden-runner egress allowlist was missing
releases.astral.sh:443 — the actual download host that astral.sh/uv/install.sh redirects to when
installing uv. This caused the Dockerfile to fail with curl: (7) Failed to connect to
releases.astral.sh.
Also adds download.pytorch.org:443 which was present in other jobs but missing from the nightly-build
job.
Note
Low Risk
Low risk: CI-only change that broadens the nightly build job’s egress allowlist to prevent Docker build failures; no runtime or application logic is affected.
Overview
Fixes nightly Docker image build failures by expanding the
step-security/harden-runneregress allowlist innightly_build.ymlto permit outbound access to additional required download hosts (notablyreleases.astral.sh:443, plus ensuringdownload.pytorch.org:443is allowed for PyTorch artifacts).Reviewed by Cursor Bugbot for commit dd1aa21. Bugbot is set up for automated code reviews on this repo. Configure here.