[Chore] Add CODEOWNERS for automated PR review assignments by sammshen · Pull Request #2950 · LMCache/LMCache

sammshen · 2026-04-03T22:34:03Z

Adds .github/CODEOWNERS to automatically request reviews from the appropriate maintainers when PRs touch specific areas of the codebase.

What this PR does / why we need it:

Special notes for your reviewers:

If applicable:

this PR contains user facing changes - docs added
this PR contains unit tests

Note

Low Risk
Adds a .github/CODEOWNERS file only; no runtime or library behavior changes, with risk limited to potential misrouting of review requests.

Overview
Adds a new .github/CODEOWNERS file mapping key LMCache areas (engine, multiprocess, distributed/L2, storage backends, integrations, docs, CI, etc.) to specific maintainers so GitHub can automatically request reviews when matching paths change.

^{Reviewed by Cursor Bugbot for commit 7aa6106. Bugbot is set up for automated code reviews on this repo. Configure here.}

gemini-code-assist

Code Review

This pull request introduces a new CODEOWNERS file to manage repository ownership and automated review assignments for the LMCache project. I have no further feedback to provide as the changes are straightforward and align with project maintenance requirements.

cursor

Cursor Bugbot has reviewed your changes and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 0f78845. Configure here.}

sammshen · 2026-04-03T22:51:21Z

@ApostaC @maobaolong would you like to take a look? we can further iterate and make it more fine-grained in the future

ApostaC

LGTM!

maobaolong · 2026-04-04T00:33:01Z

@sammshen Thanks for this great work, I found there are 7 maintainers involved, hope we can add more activity maintainers here, so that the pending review PR can reduce to a lower count.

BTW. I think the following folder @chunxiaozheng can help to maintain also, WDYT?
/lmcache/v1/cache_controller/
/lmcache/v1/distributed/
/lmcache/v1/storage_backend/
/docs/source/production/

sammshen · 2026-04-04T00:35:54Z

@maobaolong sounds good! this is just a first draft, feel free to make a follow up PR later. I will first add @chunxiaozheng to the folders you mentioned :)

DongDongJu · 2026-04-04T00:38:30Z

@sammshen Hello sam, Could you add me in /lmcache/v1/storage_backend/ as well?

sammshen · 2026-04-04T00:40:19Z

Hi @DongDongJu, adding you to storage_backends and rust and layerwise!

maobaolong

LGTM @sammshen

chunxiaozheng · 2026-04-04T01:30:40Z

hi, @sammshen , I am also quite familiar with these modules. If it's convenient, could you also add me?

/lmcache/v1/storage_backend/connector/base_connector.py
/lmcache/v1/storage_backend/connector/instrumented_connector.py
/lmcache/v1/storage_backend/connector/mooncakestore_connector.py 
/lmcache/v1/storage_backend/connector/mooncakestore_adapter.py  
/lmcache/v1/storage_backend/connector/fs_connector.py          
/lmcache/v1/storage_backend/connector/fs_adapter.py            
/lmcache/v1/storage_backend/connector/audit_connector.py       
/lmcache/v1/storage_backend/connector/audit_adapter.py

hlin99 · 2026-04-04T01:34:14Z

who is owning lmcache files (not in v1 path), protocal.py, utils.py, non_cuda_equivalent.py, etc.
seems this part is missing?

chunxiaozheng · 2026-04-04T01:35:17Z

@sammshen Besides, the modules related to memory management (/lmcache.v1.memory_management) have not been allocated yet, and I am quite familiar with this module too.

hlin99 · 2026-04-04T01:59:07Z

who is owning lmcache files (not in v1 path), protocal.py, utils.py, non_cuda_equivalent.py, etc. seems this part is missing?

Btw: if people are overloaded, I'm happy to jump in and take this limited scope. :) Since I've been focusing heavily on these areas recently, it feels like a natural starting point. Totally up to you, no pressure either way 😉

sammshen · 2026-04-05T02:23:57Z

@sammshen Besides, the modules related to memory management (/lmcache.v1.memory_management) have not been allocated yet, and I am quite familiar with this module too.

added!

sammshen · 2026-04-05T02:25:29Z

@sammshen Besides, the modules related to memory management (/lmcache.v1.memory_management) have not been allocated yet, and I am quite familiar with this module too.

added

sammshen · 2026-04-05T02:25:47Z

who is owning lmcache files (not in v1 path), protocal.py, utils.py, non_cuda_equivalent.py, etc.
seems this part is missing?

added you and @hickeyma

chunxiaozheng

LGTM!

Signed-off-by: Samuel Shen <slshen@uchciago.edu>

… adapters Signed-off-by: Samuel Shen <slshen@uchciago.edu>

hlin99 · 2026-04-05T02:35:30Z

who is owning lmcache files (not in v1 path), protocal.py, utils.py, non_cuda_equivalent.py, etc.
seems this part is missing?

added you and @hickeyma

thanks for the trust! will take responsiblity

Signed-off-by: Samuel Shen <slshen@uchciago.edu>

gemini-code-assist Bot reviewed Apr 3, 2026

View reviewed changes

cursor Bot reviewed Apr 3, 2026

View reviewed changes

Comment thread .github/CODEOWNERS Outdated

Comment thread .github/CODEOWNERS Outdated

sammshen requested review from ApostaC, deng451e, kobe0938 and maobaolong April 3, 2026 22:52

sammshen force-pushed the code-owners branch from 056a1bf to aa4894e Compare April 3, 2026 23:17

ApostaC approved these changes Apr 4, 2026

View reviewed changes

maobaolong approved these changes Apr 4, 2026

View reviewed changes

chunxiaozheng approved these changes Apr 5, 2026

View reviewed changes

[Chore] Add CODEOWNERS for automated PR review assignments

aefe5b4

Signed-off-by: Samuel Shen <slshen@uchciago.edu>

sammshen force-pushed the code-owners branch from 69c03a6 to aefe5b4 Compare April 5, 2026 02:33

Samuel Shen added 2 commits April 4, 2026 22:34

[Chore] Add sammshen to resp L2 adapter ownership

5768034

Signed-off-by: Samuel Shen <slshen@uchciago.edu>

[Chore] Add sammshen to csrc/storage_backends and native connector L2…

e672a99

… adapters Signed-off-by: Samuel Shen <slshen@uchciago.edu>

Samuel Shen added 2 commits April 4, 2026 22:35

[Chore] Add YaoJiayi to L2 eviction ownership

0cf7733

Signed-off-by: Samuel Shen <slshen@uchciago.edu>

[Chore] Add OasisGit to multiprocess and http_server ownership

7aa6106

Signed-off-by: Samuel Shen <slshen@uchciago.edu>

sammshen enabled auto-merge (squash) April 5, 2026 02:39

deng451e approved these changes Apr 5, 2026

View reviewed changes

sammshen added the full Run comprehensive tests on this PR label Apr 5, 2026

sammshen merged commit a0d6b7a into LMCache:dev Apr 5, 2026
36 checks passed

Conversation

sammshen commented Apr 3, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

sammshen commented Apr 3, 2026

Uh oh!

ApostaC left a comment

Choose a reason for hiding this comment

Uh oh!

maobaolong commented Apr 4, 2026

Uh oh!

sammshen commented Apr 4, 2026

Uh oh!

DongDongJu commented Apr 4, 2026

Uh oh!

sammshen commented Apr 4, 2026

Uh oh!

maobaolong left a comment

Choose a reason for hiding this comment

Uh oh!

chunxiaozheng commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hlin99 commented Apr 4, 2026

Uh oh!

chunxiaozheng commented Apr 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hlin99 commented Apr 4, 2026

Uh oh!

sammshen commented Apr 5, 2026

Uh oh!

sammshen commented Apr 5, 2026

Uh oh!

sammshen commented Apr 5, 2026

Uh oh!

chunxiaozheng left a comment

Choose a reason for hiding this comment

Uh oh!

hlin99 commented Apr 5, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

sammshen commented Apr 3, 2026 •

edited by cursor Bot

Loading

chunxiaozheng commented Apr 4, 2026 •

edited

Loading

chunxiaozheng commented Apr 4, 2026 •

edited

Loading