Skip to content

[MP] Fix UT after merge #2851#2931

Merged
maobaolong merged 1 commit intoLMCache:devfrom
maobaolong:fix_resp_test
Apr 3, 2026
Merged

[MP] Fix UT after merge #2851#2931
maobaolong merged 1 commit intoLMCache:devfrom
maobaolong:fix_resp_test

Conversation

@maobaolong
Copy link
Copy Markdown
Collaborator

@maobaolong maobaolong commented Apr 2, 2026

What this PR does / why we need it:

Special notes for your reviewers:

If applicable:

  • this PR contains user facing changes - docs added
  • this PR contains unit tests

Note

Low Risk
Low risk: test-only change updating an import to reference the correct RESPL2AdapterConfig location; no production logic is modified.

Overview
Fixes the RESP L2 adapter integration test to import RESPL2AdapterConfig from resp_l2_adapter (instead of native_connector_l2_adapter), aligning the factory-creation test with the current adapter/config module layout.

Written by Cursor Bugbot for commit 89635c5. This will update automatically on new commits. Configure here.

Signed-off-by: baoloongmao <baoloongmao@tencent.com>
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the import path in the integration test file 'tests/v1/distributed/test_resp_l2_adapter_integration.py' to correctly reference 'resp_l2_adapter' instead of 'native_connector_l2_adapter'. I have no further feedback to provide.

@maobaolong maobaolong requested a review from sammshen April 2, 2026 02:35
Copy link
Copy Markdown
Contributor

@sammshen sammshen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix

@maobaolong maobaolong enabled auto-merge (squash) April 3, 2026 01:20
@github-actions github-actions Bot added the full Run comprehensive tests on this PR label Apr 3, 2026
Copy link
Copy Markdown
Collaborator

@chunxiaozheng chunxiaozheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@maobaolong maobaolong merged commit ba3ba51 into LMCache:dev Apr 3, 2026
36 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

full Run comprehensive tests on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants