|
| 1 | +# SPDX-License-Identifier: Apache-2.0 |
| 2 | +""" |
| 3 | +Unit tests for RESP adapter environment variable support. |
| 4 | +
|
| 5 | +These tests verify the precedence logic (config > env var > default) |
| 6 | +without requiring a live Redis server. |
| 7 | +""" |
| 8 | + |
| 9 | +# Standard |
| 10 | +import os |
| 11 | + |
| 12 | + |
| 13 | +class TestRESPL2AdapterEnvVars: |
| 14 | + """Test env var resolution in the MP-mode RESP L2 adapter factory.""" |
| 15 | + |
| 16 | + def test_env_vars_used_when_config_empty(self, monkeypatch): |
| 17 | + """Env vars should be used when config values are empty/default.""" |
| 18 | + # First Party |
| 19 | + from lmcache.v1.distributed.l2_adapters.resp_l2_adapter import ( |
| 20 | + RESPL2AdapterConfig, |
| 21 | + ) |
| 22 | + |
| 23 | + monkeypatch.setenv("LMCACHE_RESP_HOST", "env-host") |
| 24 | + monkeypatch.setenv("LMCACHE_RESP_PORT", "7777") |
| 25 | + monkeypatch.setenv("LMCACHE_RESP_USERNAME", "env-user") |
| 26 | + monkeypatch.setenv("LMCACHE_RESP_PASSWORD", "env-pass") |
| 27 | + |
| 28 | + config = RESPL2AdapterConfig(host="", port=0, username="", password="") |
| 29 | + |
| 30 | + host = config.host or os.environ.get("LMCACHE_RESP_HOST", "") |
| 31 | + port = ( |
| 32 | + config.port |
| 33 | + if config.port |
| 34 | + else int(os.environ.get("LMCACHE_RESP_PORT", "0")) |
| 35 | + ) |
| 36 | + username = config.username or os.environ.get("LMCACHE_RESP_USERNAME", "") |
| 37 | + password = config.password or os.environ.get("LMCACHE_RESP_PASSWORD", "") |
| 38 | + |
| 39 | + assert host == "env-host" |
| 40 | + assert port == 7777 |
| 41 | + assert username == "env-user" |
| 42 | + assert password == "env-pass" |
| 43 | + |
| 44 | + def test_config_overrides_env_vars(self, monkeypatch): |
| 45 | + """Config values should take precedence over env vars.""" |
| 46 | + # First Party |
| 47 | + from lmcache.v1.distributed.l2_adapters.resp_l2_adapter import ( |
| 48 | + RESPL2AdapterConfig, |
| 49 | + ) |
| 50 | + |
| 51 | + monkeypatch.setenv("LMCACHE_RESP_HOST", "env-host") |
| 52 | + monkeypatch.setenv("LMCACHE_RESP_PORT", "7777") |
| 53 | + monkeypatch.setenv("LMCACHE_RESP_USERNAME", "env-user") |
| 54 | + monkeypatch.setenv("LMCACHE_RESP_PASSWORD", "env-pass") |
| 55 | + |
| 56 | + config = RESPL2AdapterConfig( |
| 57 | + host="cfg-host", |
| 58 | + port=8888, |
| 59 | + username="cfg-user", |
| 60 | + password="cfg-pass", |
| 61 | + ) |
| 62 | + |
| 63 | + host = config.host or os.environ.get("LMCACHE_RESP_HOST", "") |
| 64 | + port = ( |
| 65 | + config.port |
| 66 | + if config.port |
| 67 | + else int(os.environ.get("LMCACHE_RESP_PORT", "0")) |
| 68 | + ) |
| 69 | + username = config.username or os.environ.get("LMCACHE_RESP_USERNAME", "") |
| 70 | + password = config.password or os.environ.get("LMCACHE_RESP_PASSWORD", "") |
| 71 | + |
| 72 | + assert host == "cfg-host" |
| 73 | + assert port == 8888 |
| 74 | + assert username == "cfg-user" |
| 75 | + assert password == "cfg-pass" |
| 76 | + |
| 77 | + def test_defaults_when_no_env_and_no_config(self, monkeypatch): |
| 78 | + """Without env vars or config, values should be empty/zero.""" |
| 79 | + # First Party |
| 80 | + from lmcache.v1.distributed.l2_adapters.resp_l2_adapter import ( |
| 81 | + RESPL2AdapterConfig, |
| 82 | + ) |
| 83 | + |
| 84 | + monkeypatch.delenv("LMCACHE_RESP_HOST", raising=False) |
| 85 | + monkeypatch.delenv("LMCACHE_RESP_PORT", raising=False) |
| 86 | + monkeypatch.delenv("LMCACHE_RESP_USERNAME", raising=False) |
| 87 | + monkeypatch.delenv("LMCACHE_RESP_PASSWORD", raising=False) |
| 88 | + |
| 89 | + config = RESPL2AdapterConfig(host="", port=0, username="", password="") |
| 90 | + |
| 91 | + host = config.host or os.environ.get("LMCACHE_RESP_HOST", "") |
| 92 | + port = ( |
| 93 | + config.port |
| 94 | + if config.port |
| 95 | + else int(os.environ.get("LMCACHE_RESP_PORT", "0")) |
| 96 | + ) |
| 97 | + username = config.username or os.environ.get("LMCACHE_RESP_USERNAME", "") |
| 98 | + password = config.password or os.environ.get("LMCACHE_RESP_PASSWORD", "") |
| 99 | + |
| 100 | + assert host == "" |
| 101 | + assert port == 0 |
| 102 | + assert username == "" |
| 103 | + assert password == "" |
| 104 | + |
| 105 | + |
| 106 | +class TestRESPConnectorAdapterEnvVars: |
| 107 | + """Test env var resolution in the non-MP RESP connector adapter.""" |
| 108 | + |
| 109 | + def test_env_vars_used_when_extra_config_empty(self, monkeypatch): |
| 110 | + """Env vars should be used when extra_config has no credentials.""" |
| 111 | + monkeypatch.setenv("LMCACHE_RESP_USERNAME", "env-user") |
| 112 | + monkeypatch.setenv("LMCACHE_RESP_PASSWORD", "env-pass") |
| 113 | + |
| 114 | + extra_config = {} |
| 115 | + |
| 116 | + cfg_username = str(extra_config.get("username", "")) |
| 117 | + cfg_password = str(extra_config.get("password", "")) |
| 118 | + username = cfg_username or os.environ.get("LMCACHE_RESP_USERNAME", "") |
| 119 | + password = cfg_password or os.environ.get("LMCACHE_RESP_PASSWORD", "") |
| 120 | + |
| 121 | + assert username == "env-user" |
| 122 | + assert password == "env-pass" |
| 123 | + |
| 124 | + def test_extra_config_overrides_env_vars(self, monkeypatch): |
| 125 | + """extra_config values should take precedence over env vars.""" |
| 126 | + monkeypatch.setenv("LMCACHE_RESP_USERNAME", "env-user") |
| 127 | + monkeypatch.setenv("LMCACHE_RESP_PASSWORD", "env-pass") |
| 128 | + |
| 129 | + extra_config = {"username": "cfg-user", "password": "cfg-pass"} |
| 130 | + |
| 131 | + cfg_username = str(extra_config.get("username", "")) |
| 132 | + cfg_password = str(extra_config.get("password", "")) |
| 133 | + username = cfg_username or os.environ.get("LMCACHE_RESP_USERNAME", "") |
| 134 | + password = cfg_password or os.environ.get("LMCACHE_RESP_PASSWORD", "") |
| 135 | + |
| 136 | + assert username == "cfg-user" |
| 137 | + assert password == "cfg-pass" |
| 138 | + |
| 139 | + def test_host_port_env_var_fallback(self, monkeypatch): |
| 140 | + """Host/port env vars should be used when URL values are empty.""" |
| 141 | + monkeypatch.setenv("LMCACHE_RESP_HOST", "env-host") |
| 142 | + monkeypatch.setenv("LMCACHE_RESP_PORT", "9999") |
| 143 | + |
| 144 | + parsed_host = "" |
| 145 | + parsed_port = 0 |
| 146 | + |
| 147 | + host = parsed_host or os.environ.get("LMCACHE_RESP_HOST", "") |
| 148 | + port = ( |
| 149 | + parsed_port |
| 150 | + if parsed_port |
| 151 | + else int(os.environ.get("LMCACHE_RESP_PORT", "0")) |
| 152 | + ) |
| 153 | + |
| 154 | + assert host == "env-host" |
| 155 | + assert port == 9999 |
| 156 | + |
| 157 | + def test_url_overrides_env_vars(self, monkeypatch): |
| 158 | + """URL-parsed values should take precedence over env vars.""" |
| 159 | + monkeypatch.setenv("LMCACHE_RESP_HOST", "env-host") |
| 160 | + monkeypatch.setenv("LMCACHE_RESP_PORT", "9999") |
| 161 | + |
| 162 | + parsed_host = "url-host" |
| 163 | + parsed_port = 6379 |
| 164 | + |
| 165 | + host = parsed_host or os.environ.get("LMCACHE_RESP_HOST", "") |
| 166 | + port = ( |
| 167 | + parsed_port |
| 168 | + if parsed_port |
| 169 | + else int(os.environ.get("LMCACHE_RESP_PORT", "0")) |
| 170 | + ) |
| 171 | + |
| 172 | + assert host == "url-host" |
| 173 | + assert port == 6379 |
0 commit comments