fix(lb): allow null for "deprecated" field of lb type#128
Merged
LKaemmerling merged 1 commit intoLKDevelopment:masterfrom Apr 2, 2025
Merged
Conversation
cd90477 to
6a24140
Compare
Contributor
Author
|
@LKaemmerling seems like the CI failing has nothing todo with this PR. How can we go forward from here? |
LKaemmerling
approved these changes
Apr 2, 2025
Collaborator
LKaemmerling
left a comment
There was a problem hiding this comment.
Thank you! Good job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #108 by allowing
nullfor thedeprecatedparameter of a loadbalancer type.@LKaemmerling this is kind of urgent as this error currently mostly prevents usage of the loadbalancer part of this sdk. Please LMK if you wish to have any additional changes applied (or feel free to add them yourself)